Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use fs.rm instead of fs.rmdirSync to remove puppeteer profiles #112

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Use fs.rm instead of fs.rmdirSync to remove puppeteer profiles #112

wants to merge 3 commits into from

Conversation

stefanzweifel
Copy link
Owner

As reported in #110, AWS Lambda throws deprecations warnings about fs.rmdirSync().

This PR updates browsershot.js to use fs.rm().

@stefanzweifel
Copy link
Owner Author

Hm, I can replicate the issue on my local machine that I see on GitHub Actions, but I don't know how to fix this … yet.

@stefanzweifel stefanzweifel mentioned this pull request Feb 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
changelog:fixed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@stefanzweifel